Network registered contracts have absolute storage control

While it is true that any registered contract can write to any key in Storage, we view all of the separate contracts comprising the GoGoPool Protocol as a single system. A single entity (either the Guardian Multisig or in future the ProtocolDAO) will be in control of all of the contracts. In this model, if an attacker can register a single malicious contract, then they are also in full control of the Protocol itself. Because all of the contracts are treated as a single entity, there is no additional security benefit to be gained by providing access controls between the various contract’s storage keys.

Team Comment:

• We do not think this is in scope, although special operational + security care is taken to secure the guardian address (with the plan to phase out the guardian and hand over control to the ProtocolDAO).

Oracle may reflect outdated price

The price of GGP is used in the Protocol to determine collateralization ratios for minipools as well as slashing amounts. At Protocol Launch, the price of GGP will be reported via an off-chain Oracle operated by the Protocol Guardians. If the price of GGP is unknown or outdated, the Protocol cannot operate.

Team Comment:

• Distributed set of Watchers that will Pause the Protocol if the on-chain GGP Price becomes outdated. In the future, we would like to support a Chainlink Pricing Oracle to report the GGP price.

Leftover tokens in the RewardsPool

In the startRewardsCycle, the allotment each party is supposed to receive is calculated; however, due to the nature of the arithmetics, some tokens might be left out due to rounding errors.

Team Comment:

• At the end of 4 years, the ProtocolDAO will implement an inflationary mechanism in the protocol. If there are leftover tokens in the RewardsPool contract, we will distribute the remainder according to the reward rules of the protocol.

GGP Rewards Manipulation Before Distribution

Just before rewards are distributed, a NodeOp can increase their GGP stake to claim a bigger share of rewards, even if they have no minipools currently running.

A staker is eligible for the upcoming rewards cycle if they have staked their tokens for a long enough period of time. The reward amount is distributed in proportion to the amount of funds staked by the user from the total amount of funds staked by all users who claim the reward.

rewardsStartTime (tracking eligibility for rewards) is set when the first minipool is created, and users are eligible for rewards during the period their minipool ends. So a NodeOp can have 0 current minipools (but have run at least one during the period) and deposit additional GGP before rewards are distributed and take an outsized proportion of rewards.

Team Comment:

• This can only be taken advantage of when signing up for 2-4 week validation periods. Our protocol is incentivizing nodes to sign up for 3-12 month validation periods. If the team notices this mechanic being abused, Rialto may update its GGP reward calculation to disincentive this behavior.